Re: [PATCH RESEND] block:Add proper error checking to the function, add_disk

[Jens Axboe]

On 05/17/2015 05:35 AM, Nicholas Krause wrote:
> This adds proper error checking and handling to the function,
> add_disk by changing the return from void to a int. In addition
> we also change various WARN_ON statements in this function to
> proper if statements that now return a error code if there
> condition arises during this function's run. Finally we change
> the function prototype in genhd.h to return an int now rather
> then void.

Nick, I'm not going to keep looking at these. It's quite clear you are 
out of your depth, hence the review to reward ratio (as a maintainer) is 
just too high. This is the 3rd iteration of this patch in a few days, 
all different, and no comments or version logs. So please stop fixing 
FIXME patches for the block are, thanks.

This message does not require a reply.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/