Re: [PATCH 1/2] Documentation: devicetree: Add TI BQ25890 bindings

[Krzysztof Kozlowski]

2015-05-15 23:06 GMT+09:00 Laurentiu Palcu <laurentiu.palcu@xxxxxxxxx>:
> Signed-off-by: Laurentiu Palcu <laurentiu.palcu@xxxxxxxxx>
> ---
>  .../devicetree/bindings/power/bq25890.txt          | 45 ++++++++++++++++++++++
>  1 file changed, 45 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/power/bq25890.txt
>
> diff --git a/Documentation/devicetree/bindings/power/bq25890.txt b/Documentation/devicetree/bindings/power/bq25890.txt
> new file mode 100644
> index 0000000..44f50a7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/bq25890.txt
> @@ -0,0 +1,45 @@
> +Binding for TI bq25890 Li-Ion Charger
> +
> +Required properties:
> +- compatible: Should contain one of the following:
> +    * "ti,bq25890"
> +- reg: integer, i2c address of the device.
> +- ti,battery-regulation-voltage: integer, maximum charging voltage (in uV);
> +- ti,charge-current: integer, maximum charging current (in uA);
> +- ti,termination-current: integer, charge will be terminated when current in
> +    constant-voltage phase drops below this value (in uA);
> +- ti,precharge-current: integer, maximum charge current during precharge
> +    phase (in uA);
> +- ti,minimum-sys-voltage: integer, when battery is charging and it is below
> +    minimum system voltage, the system will be regulated above
> +    minimum-sys-voltage setting (in uV);
> +- ti,boost-voltage: integer, VBUS voltage level in boost mode (in uV);
> +- ti,boost-max-current: integer, maximum allowed current draw in boost mode
> +    (in uA).
> +
> +Optional properties:
> +- ti,boost-low-freq: boolean, if present boost mode frequency will be 500kHz,
> +    otherwise 1.5MHz;
> +- ti,use-ilim-pin: boolean, if present the ILIM resistor will be used and the
> +    input current will be the lower between the resistor setting and the IINLIM
> +    register setting;
> +- ti,thermal-regulation-threshold: integer, temperature above which the charge
> +    current is lowered, to avoid overheating (in degrees Celsius);

What if property is absent? The temperature will be ignored? If so,
maybe consider adding such short statement about the default state?

Rest looks good, but I am still digging through the driver and I want
to give reviewed-tag after that. This will take me some time :) .

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/