Re: [PATCH 1/3 v2] dt/bindings: Add binding for the Raspberry Pi firmware driver

From: Lee Jones
Date: Thu May 14 2015 - 04:40:52 EST


On Wed, 13 May 2015, Eric Anholt wrote:

> This driver will provide support for calls into the firmware that will
> be used by other drivers like cpufreq and vc4.
>
> Signed-off-by: Eric Anholt <eric@xxxxxxxxxx>
> ---
>
> v2: Improve commit message, point to mailbox.txt for how mboxes work.
>
> .../devicetree/bindings/arm/bcm/raspberrypi,firmware.txt | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/arm/bcm/raspberrypi,firmware.txt
>
> diff --git a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,firmware.txt b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,firmware.txt
> new file mode 100644
> index 0000000..33b0043
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,firmware.txt
> @@ -0,0 +1,16 @@
> +Raspberry Pi VideoCore firmware driver
> +
> +Required properties:
> +
> +- compatible: Should be "rasbperrypi,firmware"
> +- mboxes: Single-entry list which specifies which mailbox
> + controller and channel is used. See
> + Documentation/devicetree/bindings/mailbox/mailbox.txt
> + for the semantics of this property

That's not what it looks like to me. There is no mention of channels
in a 0 cell property. Keep it simple. How about:

Phandle to the firmware device's Mailbox.
(See: ../mailbox/mailbox.txt for more information)

> +Example:
> +
> +firmware {
> + compatible = "rasbperrypi,firmware";
> + mboxes = <&mailbox>;
> +};
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/