Re: [net-next PATCH] net: Reserve skb headroom and set skb->dev even if using __alloc_skb

From: Kevin Hilman
Date: Wed May 13 2015 - 17:36:04 EST


Alexander Duyck <alexander.h.duyck@xxxxxxxxxx> writes:

> When I had inlined __alloc_rx_skb into __netdev_alloc_skb and
> __napi_alloc_skb I had overlooked the fact that there was a return in the
> __alloc_rx_skb. As a result we weren't reserving headroom or setting the
> skb->dev in certain cases. This change corrects that by adding a couple of
> jump labels to jump to depending on __alloc_skb either succeeding or failing.
>
> Fixes: 9451980a6646 ("net: Use cached copy of pfmemalloc to avoid accessing page")
> Reported-by: Felipe Balbi <balbi@xxxxxx>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@xxxxxxxxxx>

Tested this on top of next-20150513 on an ARM/OMAP
(am335x-boneblack.dts) an it fixes the boot problem for me.

Tested-by: Kevin Hilman <khilman@xxxxxxxxxx>

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/