Re: [PATCH] leds: lp5523: add master_fader support

From: Kim, Milo
Date: Tue May 12 2015 - 04:25:45 EST


Hi Jacek and Toshi,

On 5/12/2015 4:25 PM, Jacek Anaszewski wrote:
Hi Toshi,

On 05/11/2015 09:10 PM, Toshi Kikuchi wrote:
This patch introduces 4 new attributes:
master_fader_leds
master_fader1
master_fader2
master_fader3

Fo example, to map channel 0,6 to master_fader1,
map channel 1,7 to master_fader2,
map channel 2,8 to master_fader3, and
map channel 3,4,5 to none
>
echo "123000123" > master_fader_leds

I propose to add ABI documentation for this driver. It already exposes
many custom attributes but I can't find documentation for them.

I agree with Jacek's comment but it would be better if we could see the description in lp5523 driver documentation(Documentation/leds/leds-lp5523.txt).

Best regards,
Milo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/