Re: [PATCH] livepatch: match return value to function signature

From: Jiri Kosina
Date: Mon May 11 2015 - 17:46:13 EST


On Mon, 11 May 2015, Nicholas Mc Guire wrote:

> klp_initialized() should return bool but is actually returning
> struct kobject * - convert it to a boolean explicitly.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@xxxxxxxxx>
> ---
>
> static code checking was not happy with
> ./kernel/livepatch/core.c:131 WARNING: return of wrong type
> bool != struct kobject *
>
> This adds !! to explicitly convert to boolean type.
>
> Patch was compile tested with x86_64_defconfig
>
> patch is against 4.1-rc2 (localversion-next is -next-20150508)

Applied to for-4.2/upstream. Thanks,

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/