Re: [PATCH v4 1/1] clkdev: change prototype of clk_register_clkdev()

[Russell King - ARM Linux]

On Wed, May 06, 2015 at 01:24:12PM +0300, Andy Shevchenko wrote:
> Since clk_register_clkdev() is exported for modules the caller should get a
> pointer to the allocated resources. Otherwise the memory leak is guaranteed on
> the ->remove() stage.

clk_register_clkdev() is there to assist mass clock registrations, which
typically happen in platform code.  It's there to simplify the "I need
to register this clock which I'm not going to release again".

I don't see any of these locations trying to unregister their clk from
clkdev, so I doubt this patch is needed.

Where a module wants to remove its clk from clkdev, it should register
its clk with clkdev_create() and remove it with clkdev_drop().

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/