Re: [PATCH 2/4] x86/mce/amd: Introduce deferred error interrupt handler

[Aravind Gopalakrishnan]

On 4/30/15 3:41 PM, Andy Lutomirski wrote:
> On Thu, Apr 30, 2015 at 7:49 AM, Aravind Gopalakrishnan
> <Aravind.Gopalakrishnan@xxxxxxx> wrote:
> > Changes introduced in the patch-
> >    - Assign vector number 0xf4 for Deferred errors
> >    - Declare deferred_interrupt, allocate gate and bind it
> >      to DEFERRED_APIC_VECTOR.
> >    - Declare smp_deferred_interrupt to be used as the
> >      entry point for the interrupt in mce_amd.c
> >    - Define trace_deferred_interrupt for tracing
> >    - Enable deferred error interrupt selectively upon detection
> >      of 'succor' bitfield
> >    - Setup amd_deferred_error_interrupt() to handle the interrupt
> >      and assign it to def_int_vector if feature is present in HW.
> >      Else, let default handler deal with it.
> >    - Provide Deferred error interrupt stats on
> >      /proc/interrupts by incrementing irq_deferred_count
> You're calling these "deferred interrupts" all over (e.g.
> irq_deferred_count, deferred_int_handler, etc).  That seems like it'll
> be confusing.  They're deferred errors, not deferred interrupts.

I used  the term as it is an interrupt due to the deferred error.
Would 'deferred_err_interrupt' be more apt? Maybe 
'irq_deferred_error_count' for the counter?

Thanks,
-Aravind.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/