Re: [PATCH 1/2] Regulator: mc34708: Add DT binding documentation

From: Mark Brown
Date: Thu Apr 30 2015 - 14:57:21 EST


On Tue, Apr 28, 2015 at 04:17:38PM +0200, Martin Fuzzey wrote:

> + pmic_sw3_reg: sw3 {
> + regulator-name = "SW3";
> + regulator-min-microvolt = <650000>;
> + regulator-max-microvolt = <1425000>;
> + };

These examples look awfully like you're just listiong the maximum range
allowed by the PMIC for all the supplies which is almost never something
someone would want to do on a real board. Similarly all the names are
just the name of the regulator rather than something that looks like a
board specific name.

Attachment: signature.asc
Description: Digital signature