Re: [PATCH v9 11/17] h8300: clock driver

From: Yoshinori Sato
Date: Tue Apr 28 2015 - 13:40:29 EST


At Tue, 28 Apr 2015 12:03:52 +0200,
Geert Uytterhoeven wrote:
>
> Hi Sato-san,
>
> On Tue, Apr 28, 2015 at 11:43 AM, Yoshinori Sato
> <ysato@xxxxxxxxxxxxxxxxxxxx> wrote:
> >> Clock drivers are generally not 'platform_drivers'. Please do one of two
> >> things:
> >>
> >> a) use CLK_OF_DECLARE() to register a probe function, and use a device
> >> tree for describing your hardware
> >>
> >> b) rename clk_probe() to h8300_clk_init() and just call that function
> >> from the architecture code.
> >>
> >
> > OK.
> > I'll think of "a".
>
> Which is not an option if you want to postpone DT support...

I think so.
But a lot of legacy code. I will clean up it.

> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

--
Yoshinori Sato
<ysato@xxxxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/