Re: [GIT PULL] kdbus for 4.1-rc1

From: Greg Kroah-Hartman
Date: Fri Apr 24 2015 - 02:36:14 EST


On Thu, Apr 23, 2015 at 10:56:40PM +0200, Borislav Petkov wrote:
> > Hm, this seems to be to be O(1), pretty constant, we do the same amount
> > of work all the time.
>
> The same *pile* of unnecessary and needless work. You go and collect
> *all* that data on *every* packet send?!

No, not at all, the metadata is cached, we only collect that for the
first message sent, if we didn't know it already, or we do it on the
"open" of the connection, depending on what we are gathering metadata
for.

The mc->collected test right before collecting the specific metadata is
that "cached or not" test.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/