Re: [PATCH 18/44] perf report: Add Instruction Tracing support

[Arnaldo Carvalho de Melo]

Em Thu, Apr 09, 2015 at 06:53:58PM +0300, Adrian Hunter escreveu:
> +++ b/tools/perf/Documentation/perf-report.txt
> @@ -323,6 +323,34 @@ OPTIONS
>  --header-only::
>  	Show only perf.data header (forces --stdio).
>  
> +-Z::
> +--itrace::
> +	Options for decoding AUX area tracing data. The options are:

<SNIP>

>  		     "how to display percentage of filtered entries", parse_filter_percentage),
> +	OPT_CALLBACK_OPTARG('Z', "itrace", &itrace_synth_opts, NULL, "opts",
> +			    "Instruction Tracing options",
> +			    itrace_parse_synth_opts),

I am also making this be 

 +	OPT_CALLBACK_OPTARG(0, "itrace", &itrace_synth_opts, NULL, "opts",

I.e. single letter options should be used for something more
mainstrean/frequently used, and we can also shorten it, so far, to --it:

[acme@ssdandy linux]$ perf script --i
  Error: Ambiguous option: i (could be --input or --itrace)

 usage: perf script [<options>]
    or: perf script [<options>] record <script> [<record-options>] <command>
    or: perf script [<options>] report <script> [script-args]
    or: perf script [<options>] <script> [<record-options>] <command>
    or: perf script [<options>] <top-script> [script-args]

[acme@ssdandy linux]$ perf script --it
failed to open perf.data: Permission denied

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/