Re: [PATCH 1/1] v2: Driver: hv: netvsc: call dump_rndis_message() only in netvsc debug mode

From: David Miller
Date: Tue Apr 21 2015 - 17:45:47 EST


From: sixiao@xxxxxxxxxxxxx
Date: Tue, 21 Apr 2015 14:43:55 -0700

> From: Simon Xiao <sixiao@xxxxxxxxxxxxx>
>
> Signed-off-by: Simon Xiao <sixiao@xxxxxxxxxxxxx>

This commit message is lacking an explanation why you want to do
what you are doing.

Also, we have an existing mechanism to control network device driver
debug logging output, please use it rather than invent your own
facility.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/