Re: [tpmdd-devel] [RFC PATCH 1/2] tee: generic TEE subsystem

From: Jason Gunthorpe
Date: Mon Apr 20 2015 - 11:57:27 EST


On Mon, Apr 20, 2015 at 04:54:32PM +0200, Greg Kroah-Hartman wrote:
> On Sun, Apr 19, 2015 at 11:08:00PM -0600, Jason Gunthorpe wrote:
> > I still suspect the expected way to write a new mid layer is to create
> > your own struct device and not rely on misc_device,
>
> Yes, that is the way. You can not use misc_device for anything other
> than creating the char node that your driver can use through the fileops
> you pass to it.
>
> Do not use a misc_device to create sysfs files for, or anything else, it
> will be wrong and racy, as you have pointed out.

Thanks!

Can you quickly comment on when a misc device should be used compared to
alloc_chrdev_region & cdev_add ?

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/