Re: [PATCH 1/3] regulator: max8973: get rid of extra variable for gpio validity

From: Mark Brown
Date: Mon Apr 20 2015 - 11:06:28 EST


On Mon, Apr 20, 2015 at 06:24:15PM +0530, Laxman Dewangan wrote:
> To find that dvs-gpio is valid or not, gpio API gpio_is_valid()
> can be directly used instead of intermediate variable.

> Removing the extra variable and using the gpio_is_valid().

This still looks like it's got the same issue with not doing the right
thing with platform data that uses zero as a default which is the point
in having a flag like this.

Attachment: signature.asc
Description: Digital signature