Re: [RFC][PATCH v2 06/13] usb: hcd: Add hcd add/remove functions for OTG use

From: Alan Stern
Date: Mon Apr 20 2015 - 09:56:48 EST


On Mon, 20 Apr 2015, Roger Quadros wrote:

> > I don't understand this. Why do you want to defer the add/remove if
> > the device is OTG? Don't host controller drivers expect these things
> > to execute synchronously?
>
> Sorry for the wrong information. We actually defer only the add as the
> OTG state machine might not yet be in Host ready mode.
> The remove is always synchronous and we ensure that the HCD is removed
> when usb_otg_unregister_hcd() returns.

That's okay then, but it does leave one potential hole. What happens
if usb_add_hcd() is deferred for so long that usb_remove_hcd() gets
called before the add can complete?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/