RE: [RFC,1/8] soc/fman: Add FMan MURAM support

From: Igal.Liberman@xxxxxxxxxxxxx
Date: Mon Apr 20 2015 - 04:58:32 EST




Regards,
Igal Liberman.

> -----Original Message-----
> From: Kumar Gala [mailto:galak@xxxxxxxxxxxxxxxxxxx]
> Sent: Thursday, March 12, 2015 5:57 PM
> To: Liberman Igal-B31950
> Cc: linuxppc-dev@xxxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Wood Scott-B07421
> Subject: Re: [RFC,1/8] soc/fman: Add FMan MURAM support
>
>
> On Mar 11, 2015, at 12:07 AM, Igal.Liberman <igal.liberman@xxxxxxxxxxxxx>
> wrote:
>
> > From: Igal Liberman <Igal.Liberman@xxxxxxxxxxxxx>
> >
> > Add Frame Manager Multi-User RAM support.
> >
> > Signed-off-by: Igal Liberman <Igal.Liberman@xxxxxxxxxxxxx>
> > ---
> > drivers/soc/fsl/fman/Kconfig | 1 +
> > drivers/soc/fsl/fman/Makefile | 5 +-
> > drivers/soc/fsl/fman/fm_muram.c | 174
> +++++++++++++++++++++++++++++++
> > drivers/soc/fsl/fman/inc/fm_muram_ext.h | 98 +++++++++++++++++
> > 4 files changed, 276 insertions(+), 2 deletions(-) create mode 100644
> > drivers/soc/fsl/fman/fm_muram.c create mode 100644
> > drivers/soc/fsl/fman/inc/fm_muram_ext.h
> >
>
> use lib/genalloc instead of rheap
>

Hi Kumar,
I looked into lib/genalloc allocator.
As far as I see, the genalloc allocator doesn't allow to control the memory alignment when you allocate a chunk of memory.
Two important notes regarding MURAM memory:
- The allocated memory chunks should have specific alignment (might be different in each chunk).
- The allocations must be efficient, we don't want to "waste" MURAM due to alignment issues.

> - k
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/