Re: [PATCH] Staging: i2o: fixed various code style issues in i2o_block.c

From: Dan Carpenter
Date: Mon Apr 20 2015 - 04:03:12 EST


On Sat, Apr 18, 2015 at 10:12:14PM +0200, Yorick Rommers wrote:
> From: Yorick <yorick-rommers@xxxxxxxxxxx>

Don't include a From: unless you are sending a patch someone else wrote.
Otherwise we prefer to get it from your email From. Also you forgot
your last name.

> @@ -488,8 +488,8 @@ static int i2o_block_reply(struct i2o_controller *c, u32 m,
> * Don't stick a supertrak100 into cache aggressive modes
> */
>
> - osm_err("TID %03x error status: 0x%02x, detailed status: "
> - "0x%04x\n", (le32_to_cpu(msg->u.head[1]) >> 12 & 0xfff),
> + osm_err("TID %03x error status: 0x%02x, detailed status: 0x%04x\n",
> + (le32_to_cpu(msg->u.head[1]) >> 12 & 0xfff),
> status >> 24, status & 0xffff);

The new indenting is wrong.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/