Re: [PATCH] tile: use si_int instead of si_ptr for compat_siginfo

[Chris Metcalf]

On 03/23/2015 08:02 AM, Catalin Marinas wrote:
> > @@ -121,8 +119,7 @@ int copy_siginfo_from_user32(siginfo_t *to, struct compat_siginfo __user *from)
> > >  
> > >  	err |= __get_user(to->si_pid, &from->si_pid);
> > >  	err |= __get_user(to->si_uid, &from->si_uid);
> > >-	err |= __get_user(ptr32, &from->si_ptr);
> > >-	to->si_ptr = compat_ptr(ptr32);
> > >+	err |= __get_user(to->si_int, &from->si_int);
> We have a memset(to, 0, sizeof(*to)) on arm64 in this function but I
> can't see it on tile. Some members or even half of si_ptr would be left
> uninitialised.

In the end I added a memset() for the tile compat case like you suggest 
for arm64.

Thanks!

--
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/