Re: [PATCH 1/2] net: dsa: use DEVICE_ATTR_RW to declare temp1_max

From: Sergei Shtylyov
Date: Thu Apr 16 2015 - 14:56:06 EST


Hello.

On 04/16/2015 09:38 PM, Vivien Didelot wrote:

Since commit da4759c, sysfs will only use the permissions returned by

Please also specify that commit's summary line in parens.

is_visible, instead of OR'ing them with the default file mode.

This allows us to declare temp1_max with the DEVICE_ATTR_RW macro and
just return the desired permissions for the hwmon sysfs attributes in
dsa_hwmon_attrs_visible.

Also, allow temp1_max to be write-only if set_temp_limit is provided,
but not get_temp_limit.

Signed-off-by: Vivien Didelot <vivien.didelot@xxxxxxxxxxxxxxxxxxxx>

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/