Re: [PATCH v4 10/27] IB/Verbs: Reform cm related part in IB-core cma/ucm

From: Jason Gunthorpe
Date: Thu Apr 16 2015 - 11:58:46 EST


On Thu, Apr 16, 2015 at 10:08:10AM +0200, Michael Wang wrote:
>
> Use raw management helpers to reform cm related part in IB-core cma/ucm.
>
> These checks focus on the device cm type rather than the port capability,
> directly pass port 1 works currently, but can't support mixing cm type
> device in future.

After the discussion settled, I ended up thinking that implementing
explicit device checks, for use by CM, and the BUG_ON at register to
require all ports have the same value was the best option.

It also looks like hardwired 1 won't work on switch ports, so it is no-go.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/