Re: [PATCH] dsa: mv88e6xxx: Fix error handling in mv88e6xxx_set_port_state

From: Guenter Roeck
Date: Thu Apr 16 2015 - 08:52:16 EST


On 04/16/2015 05:37 AM, Andrew Lunn wrote:
On Wed, Apr 15, 2015 at 10:12:42PM -0700, Guenter Roeck wrote:
Return correct error code if _mv88e6xxx_reg_read returns an error.

Fixes: facd95b2e0ec0 ("net: dsa: mv88e6xxx: Add Hardware bridging support")
Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Hi Guenter

Good catch. I'm surprised there is no compiler warning, possibly used
before set.

There was, actually. No idea how I missed that. Fengguang's build bots caught it.

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Thanks!

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/