Re: [PATCH v2] serial: of-serial: Remove device_type = "serial" registration

From: Arnd Bergmann
Date: Thu Apr 16 2015 - 05:31:31 EST


On Tuesday 14 April 2015 12:03:09 Michal Simek wrote:
> Do not probe all serial drivers by of_serial.c which are using
> device_type = "serial"; property. Only drivers which have valid
> compatible strings listed in the driver should be probed.
>
> When PORT_UNKNOWN is setup probe will fail anyway.
>
> Arnd quotation about driver historical background:
> "when I wrote that driver initially, the idea was that it would
> get used as a stub to hook up all other serial drivers but after
> that, the common code learned to create platform devices from DT"
>
> This patch fix the problem with on the system with xilinx_uartps and
> 16550a where of_serial failed to register for xilinx_uartps and because
> of irq_dispose_mapping() removed irq_desc. Then when xilinx_uartps was asking
> for irq with request_irq() EINVAL is returned.
>
> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>
> CC: <stable@xxxxxxxxxxxxxxx>
> ---
>

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/