Re: [PATCH v3 0/6] virtio_balloon: virtio 1 support

From: Cornelia Huck
Date: Wed Apr 15 2015 - 11:33:08 EST


On Wed, 15 Apr 2015 10:15:20 +0930
Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:

> OK, I've merged this with one change:
>
> +static void stats_sg_init(struct virtio_balloon *vb, struct scatterlist *sg)
> +{
> + sg_init_one(sg, vb->stats, sizeof(vb->stats));
> +}
> +
> ...
> - sg_init_one(&sg, vb->stats, sizeof(vb->stats));
> + stats_sg_init(vb, &sg);
>
> This is no longer a meaningful change, so I removed it.
>
> Here's the final result:
>
> From: Michael S. Tsirkin <mst@xxxxxxxxxx>
> Subject: virtio_balloon: transitional interface
>
> Virtio 1.0 doesn't include a modern balloon device.
> But it's not a big change to support a transitional
> balloon device: this has the advantage of supporting
> existing drivers, transparently.
>
> Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> Acked-by: Cornelia Huck <cornelia.huck@xxxxxxxxxx>
> Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
>
Looks good to me.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/