Re: [patch 02/39] hrtimer: Get rid of the resolution field in hrtimer_clock_base

[Frans Klaver]

On Wed, Apr 15, 2015 at 8:29 AM, Frans Klaver <fransklaver@xxxxxxxxx> wrote:
> On Tue, Apr 14, 2015 at 11:08 PM, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>> The field has no value because all clock bases have the same
>> resolution. The resolution only changes when we switch to high
>> resolution timer mode. We can evaluate that from a single static
>> variable as well. In the !HIGHRES case its simply a constant.
>>
>> Export the variable, so we can simplify the usage sites.
>
> There seems to be only one usage site outside hrtimer.c itself. That
> one only reads the value.

OK, this is incorrect. Still, if it's only meant to be read from
outside hrtimer.c:

>  Wouldn't it make sense to keep the variable
> from the interface and use a read function instead?

Thanks,
Frans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/