Re: [RFC PATCH 4/5] arm64: smp: move the pen to a header file

From: Kumar Gala
Date: Tue Apr 14 2015 - 15:41:22 EST



> On Apr 9, 2015, at 4:17 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> On Thursday 09 April 2015 12:37:10 Kumar Gala wrote:
>> From: Abhimanyu Kapur <abhimany@xxxxxxxxxxxxxx>
>>
>> Move the secondary_pen_release variable and the secondary_holding_pen
>> entry function to asm/smp_plat.h so that the other cpu ops implementations
>> can share them.
>>
>> Signed-off-by: Abhimanyu Kapur <abhimany@xxxxxxxxxxxxxx>
>> Signed-off-by: Kumar Gala <galak@xxxxxxxxxxxxxx>
>>
>
> I don't believe your SMP implementation can be so broken to require this.
> Please fix the code instead to not use a holding pen.
>
> Arnd

Yeah, I can drop this.

- k

--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/