Re: [PATCH 1/7] modpost: add strict white-listing when referencing sections.

[Quentin Casasnovas]

 On Fri, Mar 20, 2015 at 11:59:41AM +1030, Rusty Russell wrote:
> Quentin Casasnovas <quentin.casasnovas@xxxxxxxxxx> writes:
> > Prints a warning when a section references a section outside a strict
> > white-list.  This will be useful to print a warning if __ex_table
> > references a non-executable section.
> 
> Hi Quentin,
> 
>         Really pleasant to read these patches; nice work!
>

Thanks! :)

> > diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> > index d439856..7094a57 100644
> > --- a/scripts/mod/modpost.c
> > +++ b/scripts/mod/modpost.c
> > @@ -925,7 +925,8 @@ enum mismatch {
> >  
> >  struct sectioncheck {
> >  	const char *fromsec[20];
> > -	const char *tosec[20];
> > +	const char *bad_tosec[20];
> > +	const char *good_tosec[20];
> >  	enum mismatch mismatch;
> >  	const char *symbol_white_list[20];
> 
> My only gripe is that these fields are undocumented.  You maintain
> the status quo, but some comments indicating what the mean would be
> nice.  Perhaps as a separate patch.
>

Derp, I was sure I had sent a patch following your comment..  Please find
one attached to this e-mail.  It should apply cleanly on top of this
series.

> In case you need it (for the whole series):
>         Acked-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
>

Thanks again!

May I aks who's supposed to take the series?  Or maybe it needs more
acking?

Quentin