Re: [PATCH] drivers/usb/core: devio.c: Removed various errors and warnings generated by checkpatch.pl

[Joe Perches]

On Sat, 2015-04-11 at 00:53 -0700, Chase Metzger wrote:
> Fixed several errors and warnings.
[]
> Lines 1040 and 1591: changed dev_printk(KERN_DEBUG, ...) to dev_dbg(...).

These changes hav the possibly undesired effect of
removing these messages completely when DEBUG is not
#defined or when CONFIG_DYNAMIC_DEBUG is not enabled
and these messages are not specifically enabled.

> diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
[]
> @@ -1040,7 +1040,7 @@ static int proc_control(struct usb_dev_state *ps, void __user *arg)
>  		snoop_urb(dev, NULL, pipe, max(i, 0), min(i, 0), COMPLETE, NULL, 0);
>  	}
>  	if (i < 0 && i != -EPIPE) {
> -		dev_printk(KERN_DEBUG, &dev->dev, "usbfs: USBDEVFS_CONTROL "
> +		dev_dbg(&dev->dev, "usbfs: USBDEVFS_CONTROL "
>  			   "failed cmd %s rqt %u rq %u len %u ret %d\n",
>  			   current->comm, ctrl.bRequestType, ctrl.bRequest,
>  			   ctrl.wLength, i);
[]
> @@ -1591,8 +1591,7 @@ static int proc_do_submiturb(struct usb_dev_state *ps, struct usbdevfs_urb *uurb
>  	}
>  
>  	if (ret) {
> -		dev_printk(KERN_DEBUG, &ps->dev->dev,
> -			   "usbfs: usb_submit_urb returned %d\n", ret);
> +		dev_dbg(&ps->dev->dev, "usbfs: usb_submit_urb returned %d\n", ret);
>  		snoop_urb(ps->dev, as->userurb, as->urb->pipe,
>  				0, ret, COMPLETE, NULL, 0);
>  		async_removepending(as);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/