Re: [PATCH v2 09/12] ARM: dts: apq8064: Add USB OTG support for CM QS-600

From: Stephen Boyd
Date: Fri Apr 10 2015 - 13:26:47 EST


On 04/10/15 05:34, Srinivas Kandagatla wrote:
> From: Nicolas Dechesne <nicolas.dechesne@xxxxxxxxxx>
>
> This patch adds USB OTG support on USB1 for Compulab QS-600 Board.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> [Srinivas Kandagatla: fixed up regulators and status properties]
> Signed-off-by: Nicolas Dechesne <nicolas.dechesne@xxxxxxxxxx>
> ---
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts
> index fc69931..d353694 100644
> --- a/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts
> +++ b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts
> @@ -101,6 +101,14 @@
> };
> };
>
> + /* OTG */
> + usb1_phy:phy@12500000 {

Space after that ':' please.

> + status = "okay";
> + vddcx-supply = <&pm8921_s3>;
> + v3p3-supply = <&pm8921_l3>;
> + v1p8-supply = <&pm8921_l4>;
> + };
> +
> usb3_phy:phy@12520000 {
> status = "okay";
> vddcx-supply = <&pm8921_s3>;
> @@ -115,6 +123,15 @@
> v1p8-supply = <&pm8921_l23>;
> };
>
> + gadget1:gadget@12500000 {
> + status = "ok";
> + };
> +
> + /* OTG */
> + usb1: usb@12500000 {

This one is good.

> + status = "ok";
> + };
> +
> usb3: usb@12520000 {
> status = "okay";
> };


--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/