Re: [PATCH 2/2] perf data: Fix ctf_writer setupenv failure

From: Jiri Olsa
Date: Fri Apr 10 2015 - 08:38:34 EST


On Fri, Apr 10, 2015 at 03:39:25PM +0800, He Kuang wrote:
> Hi, Jérémie
> On 2015/4/10 3:57, Jérémie Galarneau wrote:
> >Hi He,
> >
> >This commit should fix the problem:
> >
> >commit a0d129162d2fdd1a99553a6cfbdf4e77ad3f7334
> >Author: Jérémie Galarneau <jeremie.galarneau@xxxxxxxxxxxx>
> >Date: Thu Apr 9 14:57:44 2015 -0400
> >
> > Fix: Allow the addition of environment fields to a frozen trace
> >
> > Commit 7f800dc7 introduced a behavior change which made it
> > impossible to add environment fields to a frozen trace (after the
> > creation of a stream).
> >
> > This fix makes it possible to add new fields to a trace's
> > environment while making it impossible to modify existing fields
> > hereby restoring CTF Writer's v1.2 behavior.
> >
> > Signed-off-by: Jérémie Galarneau <jeremie.galarneau@xxxxxxxxxxxx>
> >
> >Can you reproduce the problem with the latest Babeltrace master?
> >Otherwise, is there a branch I can checkout to try it out?
> >
> >Jérémie
>
> By updating to the latest libbabeltrace which contains commit
> a0d12916, perf ctf conversion works with or without my patch.

works nicely for me too, thanks!

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/