Re: [PATCH v4 1/9] module: Sanitize RCU usage and locking

From: Peter Zijlstra
Date: Thu Apr 09 2015 - 08:37:25 EST


On Thu, Apr 09, 2015 at 12:21:43PM +0800, Lai Jiangshan wrote:
> On 04/09/2015 12:48 AM, Peter Zijlstra wrote:
>
> > +static void module_assert_mutex_or_preempt(void)
> > +{
> > +#ifdef CONFIG_LOCKDEP
> > + int rcu_held = rcu_read_lock_sched_held();
> > + int mutex_held = 1;
> > +
> > + if (debug_locks)
> > + mutex_held = lockdep_is_held(&module_mutex);
> > +
> > + WARN_ON(!rcu_held && !mutex_held);
> > +#endif
> > +}
>
> Is rcu_lockdep_assert() suitable for it?
> (note rcu_lockdep_assert() only works when CONFIG_PROVE_RCU)

Nah, this works.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/