Re: [PATCH 9/9] tools lib traceevent: Honor operator priority

From: Arnaldo Carvalho de Melo
Date: Tue Apr 07 2015 - 09:02:15 EST


Em Tue, Apr 07, 2015 at 04:52:26PM +0900, Namhyung Kim escreveu:
> On Mon, Apr 06, 2015 at 10:45:04AM -0400, Steven Rostedt wrote:
> > > type = process_arg_token(event, right, tok, type);
> > > - arg->op.right = right;
> > > +
> > > + if (right->type == PRINT_OP &&
> > > + get_op_prio(arg->op.op) < get_op_prio(right->op.op)) {
> > > + struct print_arg tmp;
> > > +
> > > + /* swap ops according to the priority */

> > This isn't really a swap. Better term to use is "rotate".

> You're right!

> > But other than that,

> > Acked-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
>
> Thanks for the review

Ok, so just doing that s/swap/rotate/g, sticking Rostedt's ack and
applying, ok?

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/