Re: [PATCH v2] x86, selftests: Add sigreturn_32 selftest

From: Andy Lutomirski
Date: Mon Mar 09 2015 - 13:49:09 EST


On Mon, Mar 9, 2015 at 9:48 AM, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
> now I get this build failure:
>
> make[1]: Entering directory
> '/home/mingo/tip/tools/testing/selftests/x86'
> gcc -m32 -o sigreturn_32 -O2 -g -std=gnu99 -pthread -Wall sigreturn.c -lrt -ldl
> In file included from /usr/include/time.h:27:0,
> from sigreturn.c:13:
> /usr/include/features.h:374:25: fatal error: sys/cdefs.h: No such file or directory
> # include <sys/cdefs.h>
> ^
> compilation terminated.
> Makefile:18: recipe for target 'sigreturn_32' failed
> make[1]: *** [sigreturn_32] Error 1

It builds for me on Ubuntu.

It looks like your 32-bit build setup is broken. The line that's
failing to compile is:

#include <time.h>

Are you missing 32-bit headers? This test *can't* be run as a 64-bit binary.

We could enable it to work as a 64-bit binary by merging this:

http://lkml.iu.edu/hypermail/linux/kernel/1407.1/03739.html

but it would still be nice to build the 32-bit version. I could try
to rig up some makefile magic to skip building it if 32-bit headers
are missing.

--Andy

>
> :-/
>
> Thanks,
>
> Ingo



--
Andy Lutomirski
AMA Capital Management, LLC
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/