Re: [PATCH] regmap: regcache-rbtree: Fix present bitmap resize

From: Daniel Baluta
Date: Sat Mar 07 2015 - 12:36:39 EST


On Sat, Mar 7, 2015 at 6:10 PM, Lars-Peter Clausen <lars@xxxxxxxxxx> wrote:
> When inserting a new register into a block at the lower end the present
> bitmap is currently shifted into the wrong direction. The effect of this is
> that the bitmap becomes corrupted and registers which are present might be
> reported as not present and vice versa.
>
> Fix this by shifting left rather than right.
>
> Fixes: 472fdec7380c("regmap: rbtree: Reduce number of nodes, take 2")
> Reported-by: Daniel Baluta <daniel.baluta@xxxxxxxxx>
> Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx>

Thanks Lars! I confirm that this fixes the problem :).

Daniel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/