Re: [PATCH] memcg: make CONFIG_MEMCG depend on CONFIG_MMU

From: Michal Hocko
Date: Thu Mar 05 2015 - 07:56:48 EST


On Wed 04-03-15 13:21:26, Andrew Morton wrote:
> On Wed, 4 Mar 2015 16:13:01 -0500 Johannes Weiner <hannes@xxxxxxxxxxx> wrote:
>
> > I don't even care about NOMMU, this is just wrong on principle.
>
> Agree. And I do care about nommu ;)
>
> If some nommu person wants to start using memcg and manages to get it
> doing something useful then good for them - we end up with a better
> kernel. We shouldn't go and rule this out without having even tried it.

Fair enough, but shouldn't we be explicit (and honest) that the
configuration is currently broken and hardly usable?

Would it make sense to make MEMCG depend on BROKEN for !MMU? If somebody
really has an usecase then dependency on BROKEN would suggest there is a
work to be done before it is enabled for his/her configuration. I would
expect such a user would send us an email when noticing this and submit
a bug report so that we can help making it work.
---