Re: [PATCH v8 2/2] drivers/gpio: Altera soft IP GPIO driver

From: Linus Walleij
Date: Thu Mar 05 2015 - 04:37:33 EST


On Wed, Feb 11, 2015 at 9:20 AM, Tien Hock Loh <thloh@xxxxxxxxxx> wrote:

>> > These calls seem like pretty vanilla generic GPIO functions.
>> > Use GENERIC_GPIO with bgpio_init() and override the default
>> > functions only when really needed.
>> >
>> > See e.g. drivers/gpio/gpio-74xx-mmio.c
>> >
>> OK, I'll update this.
>
> I just recall that I couldn't use bgpio because the number of gpio pins
> is configurable and may not be multiple of 8, thus I'll not be updating
> this to use bgpio.

It doesn't matter. ngpio will be respected by gpio_request() so you
will not be able to request any of the GPIOs above the lower bits
anyway.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/