Re: select on undefined THERMAL_POWER_ACTOR

From: Javi Merino
Date: Wed Mar 04 2015 - 12:46:37 EST


Hi Valentin,

On Wed, Mar 04, 2015 at 01:19:25PM +0000, Valentin Rothberg wrote:
> your commit 8754d5115693 ("thermal: introduce the Power Allocator
> governor") is included in today's linux-next tree (i.e.,
> next-20150304).
>
> This patch adds a select on the Kconfig symbol THERMAL_POWER_ACTOR.
> However, THERMAL_POWER_ACTOR is not defined so that this select is a
> NOOP.
>
> @@ -99,6 +107,13 @@ config THERMAL_GOV_USER_SPACE
> help
> Enable this to let the user space manage the platform thermals.
>
> +config THERMAL_GOV_POWER_ALLOCATOR
> + bool "Power allocator thermal governor"
> + select THERMAL_POWER_ACTOR
>
> Is there a patch queued somewhere that adds this Kconfig symbol?

No there isn't, it's a leftover from a previous version of the
patches. I'll send a patch to remove it.

Thanks for reporting it!
Javi

> I
> detected the issue by running undertaker-checkpatch from the
> Undertaker tool suite (undertaker.cs.fau.de).
>
> Kind regards,
> Valentin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/