Re: Patch "x86: Store a per-cpu shadow copy of CR4" gives VirtualBox 4.3.24 indigestion.

From: Valdis . Kletnieks
Date: Tue Mar 03 2015 - 20:28:49 EST


On Tue, 03 Mar 2015 17:08:37 -0800, Andy Lutomirski said:
>
> Are they poking cr4 directly with mov? Let's see:
>
> /* Enable the VMX bit in CR4 if necessary. */
> RTCCUINTREG uCr4 = ASMGetCR4();
> if (!(uCr4 & X86_CR4_VMXE))
> ASMSetCR4(uCr4 | X86_CR4_VMXE);
>
> ASMSetCR4 is about what you'd expect.
>
> I deliberately renamed write_cr4 to __write_cr4 to catch this kind of
> thing in anything that uses the asm/ headers, but I can't do anything
> about asm code in out-of-tree modules.

Thanks for the confirmation, I've already updated the tracking bug they
were using for 4.0 issues, and will chase it further with them...

Attachment: pgpIstPOvJ3Y_.pgp
Description: PGP signature