Re: [PATCH 1/1] cgroup: fix var may be used uninitialized warning

From: Tejun Heo
Date: Tue Mar 03 2015 - 08:46:51 EST


On Tue, Mar 03, 2015 at 09:59:47AM +0100, Javier Martinez Canillas wrote:
> When building cgroup, GCC warns that the root variable
> may be used uninitialized in the cgroup_mount function.
>
> kernel/cgroup.c: In function âcgroup_mountâ:
> kernel/cgroup.c:1886:13: warning: ârootâ may be used uninitialized in this function [-Wuninitialized]
> kernel/cgroup.c:1742:22: note: ârootâ was declared here
>
> This can never happen because if the struct cgroup_root
> can't be allocated, ret is set to -ENOMEM and the error
> returned so the code using root is not reachable. But
> set root to NULL just to silence the compiler warning.

Which compiler are you on?

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/