Re: [PATCH] dmaengine: virt-dma: fix completion list manipulation

[Lars-Peter Clausen]

On 03/02/2015 10:19 PM, Robert Jarzmik wrote:
> diff --git a/drivers/dma/virt-dma.h b/drivers/dma/virt-dma.h
> index 3772032..2a3da22 100644
> --- a/drivers/dma/virt-dma.h
> +++ b/drivers/dma/virt-dma.h
> @@ -91,7 +91,7 @@ static inline void vchan_cookie_complete(struct virt_dma_desc *vd)
>   	dma_cookie_complete(&vd->tx);
>   	dev_vdbg(vc->chan.device->dev, "txd %p[%x]: marked complete\n",
>   		 vd, cookie);
> -	list_add_tail(&vd->node, &vc->desc_completed);
> +	list_move_tail(&vd->node, &vc->desc_completed);

That will break all drivers which handle this currently correctly and remove 
the descriptor from any list before calling vchan_cookie_complete.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/