[PATCH] docproc: handle realloc() failure in find_all_symbols()

From: Arjun Sreedharan
Date: Sat Feb 28 2015 - 15:07:58 EST


check realloc rc and avoid potential null dereference
and memory leak

Signed-off-by: Arjun Sreedharan <arjun024@xxxxxxxxx>
---
scripts/docproc.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/scripts/docproc.c b/scripts/docproc.c
index e267e621..438fc91 100644
--- a/scripts/docproc.c
+++ b/scripts/docproc.c
@@ -396,6 +396,10 @@ static void find_all_symbols(char *filename)
4096)) > 0) {
data_len += ret;
data = realloc(data, data_len + 4096);
+ if (data == NULL) {
+ perror("realloc");
+ exit(1);
+ }
}
} while (ret == -EAGAIN);
if (ret != 0) {
@@ -420,6 +424,10 @@ static void find_all_symbols(char *filename)
start = all_list_len;
all_list_len += count;
all_list = realloc(all_list, sizeof(char *) * all_list_len);
+ if (all_list == NULL) {
+ perror("realloc");
+ exit(1);
+ }
str = data;
for (i = 0; i < data_len && start != all_list_len; i++) {
if (data[i] == '\0') {
--
1.8.1.msysgit.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/