Re: [PATCH] power: bq27x00_battery: add bq27510 support

[Sebastian Reichel]

Hi Alexandre,

On Sat, Feb 28, 2015 at 02:22:23PM +0100, Alexandre Belloni wrote:
> Hi,
> 
> On 25/02/2015 at 23:17:48 +0100, Sebastian Reichel wrote :
> > > @@ -350,6 +378,9 @@ static int bq27x00_battery_read_cyct(struct bq27x00_device_info *di)
> > >  {
> > >  	int cyct;
> > >  
> > > +
> > 
> > spurious newline.
> > 
> > > +	if (di->chip == BQ27510)
> > > +		cyct = bq27x00_read(di, BQ27510_REG_CYCT, false);
> > >  	cyct = bq27x00_read(di, BQ27x00_REG_CYCT, false);
> > 
> > missing else?
> > 
> 
> Indeed, I just sent v2. However, I'm not too happy with all that if/else
> layering in this driver. I'll try to rework it so that it scales better.

Thanks, that would be nice.

-- Sebastian

Attachment: signature.asc
Description: Digital signature