Re: [PATCH 3/3] lib/vsprintf: Add %pC{,n,r} format specifiers for clocks

From: Geert Uytterhoeven
Date: Sat Feb 28 2015 - 03:53:38 EST


Hi Joe,

On Fri, Feb 27, 2015 at 11:55 PM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Fri, 2015-02-27 at 14:18 -0800, Andrew Morton wrote:
>> On Thu, 26 Feb 2015 12:13:03 +0100 Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>> > Add format specifiers for printing struct clk:
>> > - '%pC' or '%pCn': name (Common Clock Framework) or address (legacy
>> > clock framework) of the clock,
>> > - '%pCr': rate of the clock.
> []
>> Seems a bit cruel to teeny systems which don't implement clock. How does
>> this look? Saves 160 bytes in each powerpc build!
>
> Does this still emit a pointer value for those systems?
> Glancing at it, does it just emit NULL?

Yes, there's a "return string(buf, end, NULL, spec);" at the end.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/