Re: [PATCH 4/8] ARM OMAP2+ GPMC: change get_gpmc_timing_reg output for DTS

[Robert Abel]

Hi Roger,

On Fri, Feb 27, 2015 at 11:43 AM, Roger Quadros <rogerq@xxxxxx> wrote:
>>               time_ns_min = gpmc_ticks_to_ns(l ? l - 1 : 0);
>
> should be
>                 time_ns_min = l ? gpmc_ticks_to_ns(l - 1) + 1 : 0;
That's a micro-optimization.
>
>                 + 1ns since we don't want to fall into the previous tick bracket.
>                 for l == 0 we have t_min as 0. no need to pass it through gpmc_ticks_to_ns() or add 1 ns.
That's why the invervals are half-open. I can make them closed, no problem.

Regards,

Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/