Re: [PATCH] usb: gadget: f_mass_storage: use defined constant instead of numeric value

From: Michal Nazarewicz
Date: Fri Feb 27 2015 - 07:22:54 EST


On Thu, Feb 26 2015, Tal Shorer <tal.shorer@xxxxxxxxx> wrote:
> Signed-off-by: Tal Shorer <tal.shorer@xxxxxxxxx>

Acked-by: Michal Nazarewicz <mina86@xxxxxxxxxx>

> ---
> drivers/usb/gadget/function/f_mass_storage.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/function/f_mass_storage.c b/drivers/usb/gadget/function/f_mass_storage.c
> index 811929c..6d5ca2b 100644
> --- a/drivers/usb/gadget/function/f_mass_storage.c
> +++ b/drivers/usb/gadget/function/f_mass_storage.c
> @@ -1085,7 +1085,7 @@ static int do_inquiry(struct fsg_common *common, struct fsg_buffhd *bh)
> if (!curlun) { /* Unsupported LUNs are okay */
> common->bad_lun_okay = 1;
> memset(buf, 0, 36);
> - buf[0] = 0x7f; /* Unsupported, no device-type */
> + buf[0] = TYPE_NO_LUN; /* Unsupported, no device-type */
> buf[4] = 31; /* Additional length */
> return 36;
> }
> --
> 2.2.2
>

--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, MichaÅ âmina86â Nazarewicz (o o)
ooo +--<mpn@xxxxxxxxxx>--<xmpp:mina86@xxxxxxxxxx>--ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/