Re: [patch] mm, mempolicy: migrate_to_node should only migrate to node

From: Naoya Horiguchi
Date: Fri Feb 27 2015 - 01:21:25 EST


On Tue, Feb 24, 2015 at 03:18:06PM -0800, David Rientjes wrote:
> migrate_to_node() is intended to migrate a page from one source node to a
> target node.
>
> Today, migrate_to_node() could end up migrating to any node, not only the
> target node. This is because the page migration allocator,
> new_node_page() does not pass __GFP_THISNODE to alloc_pages_exact_node().
> This causes the target node to be preferred but allows fallback to any
> other node in order of affinity.
>
> Prevent this by allocating with __GFP_THISNODE. If memory is not
> available, -ENOMEM will be returned as appropriate.
>
> Signed-off-by: David Rientjes <rientjes@xxxxxxxxxx>

Make sense to me.

Reviewed-by: Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx>--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/