Re: [PATCH 4/4] powerpc/mpic: remove unused functions

[Arseny Solokha]

> @@ -1676,31 +1666,6 @@ void __init mpic_init(struct mpic *mpic)
>  		mpic_err_int_init(mpic, MPIC_FSL_ERR_INT);
>  }
>  
> -void __init mpic_set_clk_ratio(struct mpic *mpic, u32 clock_ratio)
> -{
> -	u32 v;
> -
> -	v = mpic_read(mpic->gregs, MPIC_GREG_GLOBAL_CONF_1);
> -	v &= ~MPIC_GREG_GLOBAL_CONF_1_CLK_RATIO_MASK;
> -	v |= MPIC_GREG_GLOBAL_CONF_1_CLK_RATIO(clock_ratio);
> -	mpic_write(mpic->gregs, MPIC_GREG_GLOBAL_CONF_1, v);
> -}
> -
> -void __init mpic_set_serial_int(struct mpic *mpic, int enable)
> -{
> -	unsigned long flags;
> -	u32 v;
> -
> -	raw_spin_lock_irqsave(&mpic_lock, flags);
> -	v = mpic_read(mpic->gregs, MPIC_GREG_GLOBAL_CONF_1);
> -	if (enable)
> -		v |= MPIC_GREG_GLOBAL_CONF_1_SIE;
> -	else
> -		v &= ~MPIC_GREG_GLOBAL_CONF_1_SIE;
> -	mpic_write(mpic->gregs, MPIC_GREG_GLOBAL_CONF_1, v);
> -	raw_spin_unlock_irqrestore(&mpic_lock, flags);
> -}
> -
>  void mpic_irq_set_priority(unsigned int irq, unsigned int pri)
>  {
>  	struct mpic *mpic = mpic_find(irq);

Thinking about it some more, I wonder whether it makes sense to propagate these
values through device tree (and refuse to apply them if they are 0), just like
what timer_group_get_freq() and timer_group_get_irq() in
arch/powerpc/sysdev/mpic_timer.c do.

Does it have any real use?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/