Re: [PATCH] ARM: EXYNOS: Don't use LDREX and STREX after disabling cache coherency

From: Kukjin Kim
Date: Thu Feb 26 2015 - 15:53:06 EST


On 02/18/15 07:24, Stephen Boyd wrote:
> On 02/16/15 05:36, Krzysztof Kozlowski wrote:
>> During CPU shutdown the exynos_cpu_power_down() is called after
>> disabling cache coherency and it uses LDREX and STREX instructions (by
>> calling of_machine_is_compatible() -> kobject_get() -> kref_get()).
>>
>> The LDREX and STREX should not be used after disabling the cache
>> coherency so just use soc_is_exynos().
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
>> Fixes: adc548d77c22 ("ARM: EXYNOS: Use MCPM call-backs to support S2R on exynos5420")
>> Cc: <stable@xxxxxxxxxxxxxxx>
>> Reported-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
>> ---
>
> Looks good to me.
>
> Reviewed-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
>
Thanks for this fix, applied.

- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/