Re: [PATCH 4/7] x86: entry.S: use JZ mnemonic after TEST, not JE

[Andy Lutomirski]

On Thu, Feb 26, 2015 at 6:13 AM, Denys Vlasenko
<vda.linux@xxxxxxxxxxxxxx> wrote:
> On Thu, Feb 26, 2015 at 12:04 AM, Borislav Petkov <bp@xxxxxxxxx> wrote:
>> On Wed, Feb 25, 2015 at 01:00:16AM +0100, Denys Vlasenko wrote:
>>> After TEST insn, JE actually performs "jump if zero",
>>> let's use JZ mnemonic instead.
>>>
>>> No code changes, but less confusion.
>>>
>>> Signed-off-by: Denys Vlasenko <dvlasenk@xxxxxxxxxx>
>>> CC: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
>>> CC: Steven Rostedt <rostedt@xxxxxxxxxxx>
>>> CC: Ingo Molnar <mingo@xxxxxxxxxx>
>>> CC: Borislav Petkov <bp@xxxxxxxxx>
>>> CC: "H. Peter Anvin" <hpa@xxxxxxxxx>
>>> CC: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
>>> CC: Oleg Nesterov <oleg@xxxxxxxxxx>
>>> CC: Frederic Weisbecker <fweisbec@xxxxxxxxx>
>>> CC: Alexei Starovoitov <ast@xxxxxxxxxxxx>
>>> CC: Will Drewry <wad@xxxxxxxxxxxx>
>>> CC: Kees Cook <keescook@xxxxxxxxxxxx>
>>> CC: x86@xxxxxxxxxx
>>> CC: linux-kernel@xxxxxxxxxxxxxxx
>>> ---
>>>  arch/x86/kernel/entry_64.S | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Acked-by: Borislav Petkov <bp@xxxxxxx>
>
> Andy, please don't take this patch yet, there are about a dozen
> more instances of TEST which need similar treatment.

I'm declaring a temporary moratorium on new development here until the
already-queued stuff is in -tip, looks okay, and we're in an
appropriate part of the cycle.  The series is already huge.

IOW I'm not applying this or the other pending patches yet.

--Andy

-- 
Andy Lutomirski
AMA Capital Management, LLC
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/