RE: [PATCH 4/4] powerpc/mpic: remove unused functions

From: Hongtao Jia
Date: Wed Feb 25 2015 - 21:53:56 EST


Hi Scott,

I'm really sorry for leave this patch like a zombie.
Now I have plan to revisit this patch.

From the previous comments the compile error was fixed.
But beyond that I have had no plan to update it.

Could you please comment on why it's still on hold?

Thanks.


> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Tuesday, February 24, 2015 5:32 AM
> To: Arseny Solokha
> Cc: Michael Ellerman; Benjamin Herrenschmidt; Paul Mackerras; linuxppc-
> dev@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Jia Hongtao-B38951
> Subject: Re: [PATCH 4/4] powerpc/mpic: remove unused functions
>
> On Thu, 2015-02-19 at 19:26 +0700, Arseny Solokha wrote:
> > + fsl_mpic_primary_get_version() is just a safe wrapper around
> > fsl_mpic_get_version() for SMP configurations. While the latter is
> > called explicitly for handling PIC initialization and setting up error
> > interrupt vector depending on PIC hardware version, the former isn't
> > used for anything.
>
> It was meant to be used by http://patchwork.ozlabs.org/patch/233211/
> which never got respun. Hongtao, do you plan to revisit that patch?
>
> -Scott
>